history colouring #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 71 71
Lines 2721 2723 +2
Branches 319 320 +1
=======================================
+ Hits 2674 2676 +2
Misses 47 47 ☔ View full report in Codecov by Sentry. |
tailuge
reviewed
Nov 15, 2023
| var colourString = "#000000" | ||
| if (balls.length > 0) { | ||
| balls.forEach(element => { | ||
| colourString = "#" + element.ballmesh.color.getHexString() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to know what ball I needed to pot next and this seemed the neatest way. It doesn't work for multiple pots of different colours yet so this is perhaps more food for thought right now than anything else.